On 02/13/2009 10:31 AM, Kinkie wrote: >> As for overflow checks, I would throw in grow() or equivalent if the >> size gets too big. Adding debugging when the size exceeds some large >> threshold is probably not needed because we can grep for that without an >> explicit debug statement. Or did you want to add a level-1 warning to >> the admin? >> > The latter. Say that a StringNg can be up to 2Gb big. > I'd rather level-1 warn at .5Gb and throw at 2Gb than just throw at 1 > (but then things will have gone bad quite long before that). If you want to warn, then warn and throw at the same time -- there is little an admin can do after seeing a "we think Squid strings are getting too large but we are not going to do anything at this point; please check back later" warning. Not a big deal either way though.
Thanks, Alex.
