On 09/14/2009 04:49 PM, Robert Collins wrote: > Just a small meta point: The new function you're adding looks like it > should be a method to me.
It should be. It is not because it is very dependent on the internal storeSwapMetaBuild() algorithm, and I wanted to keep the two functions close to each other. I added XXX to reflect the dependency. I do not think the dependency should be broken: we need to predict the packed header size and do not want to spend CPU cycles on packing twice or make the code even worse by adding "if (really_pack)" statements to storeSwapMetaBuild() and friends. Thank you, Alex.
