On Mon, 19 Apr 2010 22:33:37 +0200, Henrik Nordstrom <hen...@henriknordstrom.net> wrote: > tor 2010-04-15 klockan 22:19 +1200 skrev Amos Jeffries: >> ------------------------------------------------------------ >> revno: 10399 >> committer: Amos Jeffries <squ...@treenet.co.nz> >> branch nick: trunk >> timestamp: Thu 2010-04-15 22:19:26 +1200 >> message: >> Back out the tweak on rev10398. > > >> globals.cc: globals.h mk-globals-c.awk >> - $(AWK) -f $(srcdir)/mk-globals-c.awk < $(srcdir)/globals.h > $@ || >> $(RM) -f $@ && exit 1 >> + $(AWK) -f $(srcdir)/mk-globals-c.awk < $(srcdir)/globals.h > $@ || >> $(RM) -f $@ > > Why? >
I had bound the exit(1) to success of the rm command, not failure of the awk. When we get time to sort out the shell nesting of automake it needs to be added back in to ensure the make runs exit on awk failure. For now it still fails later anyway as a linkage failure. So the build will still abort. Just not in the best place. Amos
