Alex Rousskov wrote:
Fixed IpAddress port printing for ports higher than 9999:
snprintf includes zero-terminator in its size limit, so 7
rather than 6 bytes are needed to snprintf a colon followed
by 5 port digits.
Whether the bug has any runtime effects in the current code,
I do not know, but I did waste a few hours following
misleading debugging output.
Alex.
+1. Please commit with tweak:
MAX_IPSTRLEN definition needs +1 as well to prevent this introducing a
buffer overflow.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.1
