Re: Patch for squidclient

On 08/14/2010 02:10 PM, Markus Moeller wrote:

Please find attached a patch to add Proxy- and WWW-Authenticate.


* GSSAPI_token not documented.

* check_gss_err not documented.

I did not see any function with documentation. I have added some lines now. What should be the format ?

* It would be nice to remove gotos from the new code.


Done

* porxy misspelled; did not check for other typos


Fixed

* Please try to remove whitespace modifications that are unrelated to your patch.


I used formater.pl, which must have introduced them.

* Is tools/Makefile.in under revision control? If not, it should not be in the patch.

Not sure if it is under revision control, but I get it with rsync. I have removed it from the patch


Thank you,

Alex.


Thank you

Markus

Reply via email to