On Tue, 24 Aug 2010 17:21:08 -0600, Alex Rousskov <[email protected]> wrote: > On 08/24/2010 04:39 PM, Henrik Nordström wrote: >> mån 2010-08-23 klockan 21:44 -0600 skrev Alex Rousskov: >> >>> I am not going to commit this optimization until there is consensus on >>> how to handle the major/minor naming conflict with GCC. >> >> The #undef should be fine, as long as we do it after including any >> system headers which may depend on those macros. > > Or, if Amos' rules are followed and system headers are always included > _after_ Squid ones (the problem would not even exist in this case).
Um, are you saying that header sequence cause the problem? or that it resolves it? > >> If not, rename them? >> >> And perhaps get rid of most if not all direct member accesses isolating >> the problem? > > We could provide accessors, but the good ones will also conflict with > the macros. Thus we have two options: > > 1) #undef > 2) rename > > Alex. I know its not related directly to the member naming. But this class as a whole is used for other protocol beyond HTTP. So should it not be "class ProtoVersion"? and moved to the protocol-agnostic location from SourceLayout? Amos
