On 11/17/2010 04:12 PM, Amos Jeffries wrote:
* creates namespace Comm::IO for the read and write functionality to
exist.

Do we really need the Io sub-namespace? What Comm[unication] namespace
parts are not about I/O? For example, all code already in src/comm/, and

pretty much everything in comm.cc is also about I/O. If you are not
sure, let's drop the Io namespace from Comm.

For the record  comm.cc currently handles read IO, write IO, FD
management, event queues, socket opening, delay pool queueing, destination
DNS resolving. It is slightly unclear how much of that will remain in comm
layer and how much will be pushed out into better scopes.

In your list, only the DNS resolution seems out of Comm scope to me.

I'm happy with removing the ::Io namespace for now. Will do before commit.

Thank you.

Since these are few and all cosmetic is this a +1 from you?

Yes, I guess. The perfectionist in me resists giving +1 for patches I cannot fully audit :-).

Cheers,

Alex.

Reply via email to