Hello Squid Developers :)

Please correct me if I am wrong... as of the latest stable version of Squid 3.1.10 it is *NOT* possible to give Squid back the adapted HTTP request with ICAP/1.0 200 Ok reply from ICAP server?

Well, what I see in ModXAct.cc(789) the 200 Ok response coming from ICAP server MUST have an encapsulated HTTP response headers... but actually when we adapt the HTTP request we may just have tweaked for example some of its parameters... say URL or Cookie or whatever... leaving everything other intact.

Does it mean that it is a bug of Squid or just that I overlooked something?

Best regards,
sich


bool Adaptation::Icap::ModXact::validate200Ok()
{
        ... skipped ...

    if (ICAP::methodReqmod == service().cfg().method) {
        if (!gotEncapsulated("res-hdr") && !gotEncapsulated("req-hdr"))
             ^^^^^^^^^^^^^^^^^^^^^^^^^
            return false;

        return true;
    }

    return false;
}

Reply via email to