Hi,

On 12/01/11 00:14, Henrik Nordström wrote:
tis 2011-01-11 klockan 11:37 +0100 skrev Fabian Hugelshofer:

What do you think about removing the special handling for Mozilla/3 and
Netscape/3 agents from HttpMsg.cc?

+1 from me.

How large is the chance that there is still an affected browser in use?

Pretty close to none. And if there are those can be fixed in their local
configuration to disable the use of persistent connections.

Thank you for your positive feedback.

I removed the discussed parts from HttpMsg.cc. See the attached patch.

In which versions would this be included? Squid 3.2?

Regards,

Fabian
=== modified file 'src/HttpMsg.cc'
--- src/HttpMsg.cc	2010-09-03 02:04:59 +0000
+++ src/HttpMsg.cc	2011-01-25 07:06:44 +0000
@@ -326,21 +326,6 @@
          */
         return !httpHeaderHasConnDir(&header, "close");
     } else {
-        /*
-         * Persistent connections in Netscape 3.x are allegedly broken,
-         * return false if it is a browser connection.  If there is a
-         * VIA header, then we assume this is NOT a browser connection.
-         */
-        const char *agent = header.getStr(HDR_USER_AGENT);
-
-        if (agent && !header.has(HDR_VIA)) {
-            if (!strncasecmp(agent, "Mozilla/3.", 10))
-                return 0;
-
-            if (!strncasecmp(agent, "Netscape/3.", 11))
-                return 0;
-        }
-
         /* for old versions of HTTP: persistent if has "keep-alive" */
         return httpHeaderHasConnDir(&header, "keep-alive");
     }

Reply via email to