On Sun, 27 Mar 2011 13:48:55 +0300, Tsantilas Christos wrote:
This is my latest patch.
If there are no any objections I will commit it to trunk later today.
On 03/26/2011 12:47 AM, Amos Jeffries wrote:
On 26/03/11 05:14, Tsantilas Christos wrote:
On 03/25/2011 01:31 PM, Amos Jeffries wrote:
Just a question.
What is this about?
+//TODO: capitalize globals
Nothing important I think.
If I am not wrong, the global functions should start with a capital
letter so we should rename the getErrorName and getErrorDescr to
GetErrorName and GetErrorDescr respectively
The static global ones should yes. Please do so for any new ones
added
or newly made global/static by this patch.
OK, the new GetErrorDescr global function now starts from a capital
letter.
If you have time, a separate "Cleanup:" patch needs to go in for the
ones which are existing prior to your change.
The functions parseErrorString and getErrorName should renamed to
ParseErrorString and GetErrorName. Looks easy, ony 2-3 changes. I
will
commit a separate patch immediately after apply this one.
Regards,
Christos
+1. Okay by me.
Amos
