On 01/05/11 12:49, Alex Rousskov wrote:
On 04/30/2011 09:37 AM, Amos Jeffries wrote:
Version 3. Containing everything discussed so far except the
optimization of base64_decode_len()
I do not see any bugs. You may want to check whether we can demand that
the decoded packet length is exactly the size of the ntlmhdr structure in
+ if (decodedLen< sizeof(ntlmhdr)) { /* decoding failure,
return error */
but that is probably not a big deal either way.
This is just a check that it is big enough to hold the common NTLMSSPI
wrapper header. Once that header is validated we get the type of GSSAPI
packet inside the data portion and a second type-specific function
checks the full size matches.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.12
Beta testers wanted for 3.2.0.7 and 3.1.12.1
