On 02/07/11 08:44, Tsantilas Christos wrote:
On 07/01/2011 12:07 PM, Tsantilas Christos wrote:
The above can be modified as follows:
- Always increase the "theBusyConns" counter inside
"ServiceRep::getConnection" method (even if we did not return a
connection)
- (1)Define a new method "ServiceRep::noteConnectionFailed" which will
decrease the "theBusyConns" counter and will be called from Xaction when
the connection failed OR (2) move the "open-connection" logic in
ServiceRep, where the theBusyConns will be decreased on connection
failures. (The second maybe is not easy...)
- Decrease the "theBusyConns" counter inside ServiceRep::putConnection
The 4th version of the patch, which implements the above .
It still needs some testing, I am posting it here in the case someone
wants to test it.
Makes sense. Thank you.
One documentation change for the commit:
src/adaptation/icap/ServiceRep.cc chunk @567
there is an "XXX: but ... idle pconn to *where*?"
- that needs to be erased. The problem its talking about is fixed by
this patch.
(NP: I cant test)
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.13
Beta testers wanted for 3.2.0.9
