On 09/07/2011 05:48 AM, Amos Jeffries wrote:

> configure.ac:
>  * rock store build conditions seem a bit out of sync with the intro
> documentation. The docs imply that rock will work with just blocking I/O
> without SMP mode.

Yes, you still need to have SMP _support_, even if SMP mode is off. I
think we can relax or even remove that requirement.


>   The build checks requires that IpcIo and shm_open are supported simply
> to build it in. Could that be made to allow blocking-only builds with a
> configure-time check for IpcIo?
>  Don't let this block the merge. Just make it clear in the docs and add
> to the TODO list if it is.

Sounds good, we will work on it.


> src/Makefile.am:
>  * please check for 8-spaces "        " on line wrapping and replace
> with tabs.

Done. I thought source formatting scripts (which I ran) would take care
of spacing.


Thank you,

Alex.

Reply via email to