On 07/09/11 12:08, Alex Rousskov wrote:
Hello,
Attached compressed patch contains changes related to SMP shared
memory cache and Rock Store support. Most of these changes have been
posted earlier for preview. The patch accumulates more than two years
worth of work and, at 20K lines, is probably too huge and too difficult
to audit correctly, for which I do apologize. I should have found a way
to merge parts of this earlier.
The patch preamble is several pages long and attempts to document all
major changes.
Third block of fixes ...
src/ipc/Kid.h:
* re: "TODO: processes may not be kids; is there a better place to put
this?"
- if you want to create a string array for debugs() display it will
need a file of its own with same name as the enum and to be in the Ipc
namespace. Otherwise Kid.h is a good place for now.
src/ipc/StrandSearch.h:
* sys/types.h is guaranteed to be included by config.h in the .cc
please remove
src/ipc/mem/Pages.cc:
* please implement the "TODO: adjust cache_mem description to say ..."
and remove.
src/refresh.cc:
* !! been looking for the details of this bug recently. Please commit
separately so I can port to 3.1.
src/store.cc:
* in StoreController::maintain() please update the WARNING: to
DBG_CRITICAL
src/structs.h:
* "///< number of disk processes required ..."
- the "<" refers doxygen to variable on previous logical line
(n_configured). I think you mean just /// to refer to following line
(n_strands)
src/tests/stub_MemStore.cc and src/tests/stub_Port.cc:
* the STUB macros provide STUB_RETVAL(x) for functions with return
values. You may want to use that and cut out a lot of lines.
src/tests/testRock.cc and src/tests/testRock.h:
* ??
I noticed quite a few TODO comments about splitting in-transit objects
out of memory cache and the global store_table (that the index?). I
think its about time we discussed how that and the changes in this patch
will impact on our future goal of implementing collapsed forwarding in
squid-3.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.15
Beta testers wanted for 3.2.0.11
