On Tue, 20 Sep 2011 13:48:39 +1200, Amos Jeffries <[email protected]> wrote: > On Tue, 20 Sep 2011 13:44:24 +1200, Amos Jeffries wrote: > > On Tue, 20 Sep 2011 02:38:08 +0400, Dmitry Kurochkin wrote: > >> Hello. > >> > >> This is a small and simple fix for cache_dir reconfiguration. > >> > >> > >> SwapDir::type() returns C strings which should be compared with > >> strcmp(3) instead of checking pointers for equality. > >> > >> Regards, > >> Dmitry > > > > > > eek! > > > > +1 please commit. > > > > Amos > > > Actually. Please check if this fixes: > http://bugs.squid-cache.org/show_bug.cgi?id=3054 > > and reference the bug the usual way if it does. >
The bug is about adding new cache_dir, not reconfiguring existing ones. So it is not related AFAICT. Also, there is support for adding new cache dirs during reconfigure, looks like it should work. (Though I think it would not work properly for shared Rock store.) Unfortunately, the bug has no logs... Regards, Dmitry > Amos
