On Wed, 30 Nov 2011 18:11:52 +0100, Kinkie wrote:
Hi all, I have noticed that typedefs.h contains a few typedefs of structs which do not seem to be defined anywhere, and are not used anywhere. This patch removes them.
+1. Please commit useless code removals from typedefs.h, protos.h, structs.h on discovery.
A different case is storeSwapLogData, which is used in src/test_cache_digest.cc, and whose removal doesn't fail the build test for some reason. I haven't removed it in the attached patch.
That would be because the test_cache_digest is never actually run/tested :( that needs a fix.
The typedef appears could be moved to the tests .cc file. Amos
