On 4/12/2011 11:13 a.m., Kinkie wrote:
Hi all,
yet another struct-turned-class.
It is more or less a straightforward porting, with minimal interface
extensions aimed at keeping the MemBuf data-member private.
For simplicity's sake I've added one invariant condition: during a
HttpBody lifetime, the MemBuf data member is never NULL.
Please review
HttpBody::setMb():
* please note that protect from assign-to-self is omitted due to non-existence
of copy constructor.
If such a constructor is ever added the protection will be needed.
HttpBody.h:
* do you need to have the filename repeated and "Created On" section of
copyright? we use AUTHOR: prefix instead to assign copyrights with the Squid blurb.
* packInto() docs:
s/output operation/output operation/
s/note:/note/
* in the hasContent() docs
s/contents/content/
consider using \return instead of "check" in "check whether..."
* contentSize(), content() docs
use \return instead of just the word.
+1 from me.
Amos
