On Fri, Dec 16, 2011 at 10:09 AM, Amos Jeffries <[email protected]> wrote: > As Henrik mentioned a few days ago the NTLM and Negotiate auth logics are > pretty much cut-n-paste copies of each other with a bit of symbol renaming > and a slight difference in bugs. The more I abstract the objects back to a > single core auth library with inherited scheme-specific objects, the more > this becomes visible. > > I've been wondering whether it would be a good idea to make these two > components libraries inherit from each other one way or another instead of > independently from the abstracted auth core objects. > > Along those lines, and since Negotiate is a combo of both Kerberos and NTLM > handling I am considering making the older NTLM component inherit from > Negotiate. So when NTLM is enabled at build we get NTLM and Negotiate/NTLM > support. When only Negotiate is enabled we get Negotiate/NTLM and > Negotiate/Kerberos. And when both components are enabled we get NTLM, > Negotiate/NTLM, and Negotiate/Kerberos. > > > Thoughts?
+2 (as it is more than +1). I like your plan, it seems to me that it gives the best results (for the least efforts). -- /kinkie
