On 21/01/2012 4:01 a.m., Kinkie wrote:
On Fri, Jan 20, 2012 at 3:43 PM, Amos Jeffries<[email protected]> wrote:
On 21/01/2012 2:46 a.m., Kinkie wrote:
I can handle that.
In most cases what is needed is extra header files. Should I go
through the normal review process or are these harmless enough to be
merged directly?
Thank you. Normal process I think for this part, just in case we miss
something in the picking :)
I have a bit of change half done to polish up PRIuSIZE, but the rest of
the
branch is open pickings.
I've kicked off another 3.ALPHA-branch-matrix test to verify its working
everywhere, the last few runs failed in the purge code, so its hard to
tell
if there was anything else later on.
Ok, will do.
First thing I'd like to address is SourceLayout-related: it scatters
src/* with "Config.h" files. Guess what happens when anything in any
of those directories includes "config.h" ? big mess.
I'd still like to get to the real cause of that mess. Case sensitivity is
not the issue.
The set of -I paths set by src/Common.am is explicitly limited to exclude
the "." directory and thus require the local xyz/Config.h files to have
sub-dir paths on their #include lines.
Whatever is causing the brokenness is somewhere in the toolchain violating
our build specs.
The ultimate end for include/config.h file was to be renamed to
include/squid.h when the old squid.h was emptied out.
That could be done early like Robert was suggesting a while back;
* moving todays squid.h to squid-old.h
* updating all the existing #include for squid.h to squid-old.h
* updating all the #include for config.h to squid.h
mess disappears.
That would mean touching 407 files.
Are you sure it is better than changing the conventions on the 9
Config.h files currently in the sources?
I think it is worth it. Closes off this brokenness long-term and move
the compat shuffling one big step closer to completion.
Amos
