See <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/466/changes>
Changes: [Alex Rousskov] Bug 3466: Adaptation stuck on last single-byte body piece Changed StoreEntry::bytesWanted(range) to return range.end when the entry can accommodate range.end bytes. This makes it possible to use that method for single-byte ranges. Old code returned zero for such ranges, which was difficult to distinguish from situations where no bytes were wanted at all. TODO: The StoreEntry::bytesWanted(range) API is left undocumented because it seems to be slightly broken and/or inconsistent with callers and with the DelayId::bytesWanted(min, max) API. AFAICT, we should convert StoreEntry::bytesWanted API from range-based to min/max-based or even just max-based. Store Entry API does not use the lower end of the range (except for the now-removed assertion that the range is not empty). I suspect that Store API was meant to be used with (first, last+1) "byte position" parameters (returning the number of bytes wanted) while the DelayId API was meant to be used with (min, max) "number of bytes" parameters. However, StoreEntry::bytesWanted implementation does not follow this assumption so perhaps my speculation is wrong and there are more problems, including this change. ------------------------------------------ Started by upstream project "3.HEAD-amd64-CentOS-5.3" build number 1884 Building remotely on obsd-48-x64 in workspace <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> $ bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> info result: bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> returned 0. Command output: "12128 [email protected] " stderr: "" [3.HEAD-amd64-OpenBSD] $ bzr pull --overwrite http://bzr.squid-cache.org/bzr/squid3/trunk/ http://bzr.squid-cache.org/bzr/squid3/trunk is permanently redirected to http://bzr.squid-cache.org/bzr/squid3/trunk/ M src/Server.cc M src/Store.h M src/client_side_request.cc M src/store.cc All changes applied successfully. Now on revision 12129. $ bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> info result: bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> returned 0. Command output: "12129 [email protected] " stderr: "" [3.HEAD-amd64-OpenBSD] $ bzr log -v -r revid:[email protected]:[email protected] --long --show-ids Getting local revision... $ bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> info result: bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD/ws/> returned 0. Command output: "12129 [email protected] " stderr: "" RevisionState revno:12129 revid:[email protected] [3.HEAD-amd64-OpenBSD] $ /bin/sh -xe /tmp/hudson6573883708896616407.sh + /root/bin/hudson-build /tmp/hudson6573883708896616407.sh[3]: /root/bin/hudson-build: not found Build step 'Execute shell' marked build as failure
