On 07/04/2012 04:52 PM, Amos Jeffries wrote: > On 05.07.2012 08:34, Henrik Nordström wrote: >> ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: > > Alex, > before starting I went through each of the helper response styles we > have and documented exactly what comes and goes > (http://wiki.squid-cache.org/Features/AddonHelpers) to determined that > none of the response formats started with a token containing [a-z0-9] > then "=". We are *not* starting from a random-input state where <blob> > can overlap with <key>.
I thought you wanted a general format. I agree that current bodies will not clash with current keys. Alex. > Anything which does not start with a registered <result> status code, is > <blob> automatically. The ones which do use <result> are safely mapped > to the key-pair format based on the presence of a valid "key=" token, or > its absence indicating <blob> to be handled by the old parser. > > Have a look through that wiki page at the set of "Result line sent back > to Squid" and its clear. > The proposed shared format is *exactly* what external ACL already > processes. It also if you look at the code has the proposed background > <blob> for backward compatibility with some squid-2.5 era helpers which > only sent a <reason> field in plain-text (random input! yuck, as an > established PoC it seems not to have had any complaints). > > Amos
