On 22/08/2012 3:17 a.m., Kinkie wrote:
It is worth it if we want to enforce the order. Humans will miss
out-of-order includes during review process. This is something a program
does best.
Yes. At the same time include order is mostly convenience (although it
uncovered two issues with missing headers).
What about reordering #includes in .h files? Why limit this to .cc?
I aimed at the big target first; it's already a pretty big patch.
The bulk of it is also automatic for the script.
If possible I think we should do this as a manual patch to:
* do things like adding new headers needed to keep compile working,
* add/remove empty lines as necessary for the new script,
* add the script
But leave sorting to a followup patch applied by maintenance automation.
That way if people have trouble porting things past the change they can
merge up to the script addition. Run it on the branch then continue
merging forward through the bulk sort.
Amos
