On 23/09/2012 5:01 a.m., Kinkie wrote:
I suggest adding "#if HAVE_UNISTD_H" (because other Squid code uses
that, albeit not consistently) and committing to see what happens on the
build farm.
Will do - however I'm quite convinced that for so well-codified
headers we should rather remove it everywhere.
We have a bit of a collision in the coding guidelines which make
wrapping system includes mandatory. But a lot of the code from
Measurement factory in particular has been added without any wrappers.
I'm open to a change there, but we neeed to discuss that a bit first.
You may also want to check for NULL return for getcwd() (our main.cc
does that) and use "." if it is NULL, but such cases should be rare.
The man page mentions that getcwd will always return the buffer
argument that was passed.
I'm using the return value only because there is one and the compiler
will complain if I don't use it.
But sure, after all it's just one line of code.
I think in those circumstances we should be checking if the return is
NULL *or empty string*. That might be a bug in main.cc
Polishing and committing.
This probably also belongs to 3.2
Yes. Will port when its proven working okay in HEAD, so please keep
simple ;-).
Amos
