See <http://build.squid-cache.org/job/3.HEAD-amd64-opensuse/210/changes>
Changes: [Amos Jeffries] Bug 3130: helpers are crashing too rapidly As discussed quite many months ago. This reduces the FATAL when helpers crash/exit to a critical level ERROR have responded with useful reply to at least one lookup. The result is that Squid can now cope with helpers written in languages which cannot loop infinitely. For example; PHP helpers often exit after a timeout, broken scripts written to respond and exit immediately, and helpers which encounter some permissions error and respond only with "ERR" or "BH" results before aborting. [Amos Jeffries] Polish: de-duplicate helper statistics objects * Combine the stats structure on per-helper server classes. For more consistent statistic gathering. * Add initStats() method to initialize statistics variables correctly. Previously only done for some counters on stateless helper objects. * Add missing accounting of pending lookups in stateful helper code. * Add counter for replies received from the helper. * Add reporting of replies received back from each helper. There are no logic or decision making logics affected by these changes. The new increment/decrement and stats are purely affecting statistical report outputs. FUTURE TODO: * replace the 'busy' flag on stateful helpers with pending>0 check as used by stateless helpers to indicate queue count. ------------------------------------------ [...truncated 7124 lines...] Testing ../../src/HttpHdrScTarget.h ...Ok. Testing ../../src/wccp2.h ...Ok. Testing ../../src/PingData.h ...Ok. Testing ../../src/store_swapin.h ...Ok. Testing ../../src/TimeOrTag.h ...Ok. Testing ../../src/HttpBody.h ...Ok. Testing ../../src/StoreMetaSTD.h ...Ok. Testing ../../src/event.h ...Ok. Testing ../../src/MemStore.h ...Ok. Testing ../../src/DescriptorSet.h ...Ok. Testing ../../src/store_key_md5.h ...Ok. Testing ../../src/comm.h ...Ok. Testing ../../src/tools.h ...Ok. Testing ../../src/ftp.h ...Ok. Testing ../../src/LoadableModules.h ...Ok. Testing ../../src/stmem.h ...Ok. Testing ../../src/CommRead.h ...Ok. Testing ../../src/CompositePoolNode.h ...Ok. Testing ../../src/Server.h ...Ok. Testing ../../src/wccp.h ...Ok. Testing ../../src/DelayTagged.h ...Ok. Testing ../../src/swap_log_op.h ...Ok. Testing ../../src/win32.h ...Ok. Testing ../../src/HierarchyLogEntry.h ...Ok. Testing ../../src/StoreClient.h ...Ok. Testing ../../src/structs.h ...Ok. Testing ../../src/HttpHeaderMask.h ...Ok. Testing ../../src/unlinkd.h ...Ok. Testing ../../src/client_side_reply.h ...Ok. Testing ../../src/StoreMetaSTDLFS.h ...Ok. Testing ../../src/defines.h ...Ok. Testing ../../src/multicast.h ...Ok. Testing ../../src/store_rebuild.h ...Ok. Testing ../../src/HttpHeaderTools.h ...Ok. Testing ../../src/RemovalPolicy.h ...Ok. Testing ../../src/Packer.h ...Ok. Testing ../../src/DelaySpec.h ...Ok. Testing ../../src/AsyncEngine.h ...Ok. Testing ../../src/StoreSwapLogData.h ...Ok. Testing ../../src/HttpMsg.h ...Ok. Testing ../../src/mime_header.h ...Ok. Testing ../../src/ICP.h ...Ok. Testing ../../src/DnsLookupDetails.h ...Ok. Testing ../../src/peer_userhash.h ...Ok. Testing ../../src/cache_cf.h ...Ok. Testing ../../src/Debug.h ...Ok. Testing ../../src/ExternalACLEntry.h ...Ok. Testing ../../src/CpuAffinityMap.h ...Ok. Testing ../../src/HttpRequestMethod.h ...Ok. Testing ../../src/SquidString.h ...Ok. Testing ../../src/StoreMetaVary.h ...Ok. Testing ../../src/fde.h ...Ok. Testing ../../src/StatCounters.h ...Ok. Testing ../../src/CommonPool.h ...Ok. Testing ../../src/peer_sourcehash.h ...Ok. Testing ../../src/HttpHdrSc.h ...Ok. Testing ../../src/AuthReg.h ...Ok. Testing ../../src/NullDelayId.h ...Ok. Testing ../../src/DiskIO/ReadRequest.h ...Ok. Testing ../../src/DiskIO/DiskIOModule.h ...Ok. Testing ../../src/DiskIO/DiskIOStrategy.h ...Ok. Testing ../../src/DiskIO/DiskFile.h ...Ok. Testing ../../src/DiskIO/WriteRequest.h ...Ok. Testing ../../src/DiskIO/IORequestor.h ...Ok. Testing ../../src/DiskIO/Mmapped/MmappedFile.h ...Ok. Testing ../../src/DiskIO/Mmapped/MmappedDiskIOModule.h ...Ok. Testing ../../src/DiskIO/Mmapped/MmappedIOStrategy.h ...Ok. Testing ../../src/DiskIO/AIO/AIODiskFile.h ...Ok. Testing ../../src/DiskIO/AIO/async_io.h ...Ok. Testing ../../src/DiskIO/AIO/aio_win32.h ...Ok. Testing ../../src/DiskIO/AIO/AIODiskIOModule.h ...Ok. Testing ../../src/DiskIO/AIO/AIODiskIOStrategy.h ...Ok. Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskFile.h ...Ok. Testing ../../src/DiskIO/DiskThreads/CommIO.h ...Ok. Testing ../../src/DiskIO/DiskThreads/DiskThreads.h ...Ok. Testing ../../src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h ...Ok. Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h ...Ok. Testing ../../src/DiskIO/IpcIo/IpcIoFile.h ...Ok. Testing ../../src/DiskIO/IpcIo/IpcIoDiskIOModule.h ...Ok. Testing ../../src/DiskIO/IpcIo/IpcIoIOStrategy.h ...Ok. Testing ../../src/DiskIO/DiskDaemon/DiskdFile.h ...Ok. Testing ../../src/DiskIO/DiskDaemon/diomsg.h ...Ok. Testing ../../src/DiskIO/DiskDaemon/DiskdIOStrategy.h ...Ok. Testing ../../src/DiskIO/DiskDaemon/DiskdAction.h ...Ok. Testing ../../src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h ...Ok. Testing ../../src/DiskIO/Blocking/BlockingIOStrategy.h ...Ok. Testing ../../src/DiskIO/Blocking/BlockingFile.h ...Ok. Testing ../../src/DiskIO/Blocking/BlockingDiskIOModule.h ...Ok. .. OK (2) PASS: tests/testACLMaxUserIP . OK (1) PASS: tests/testBoilerplate .. OK (2) PASS: tests/testCacheManager . OK (1) PASS: tests/testDiskIO ..Actual Text: Last event to run: last event Operation \tNext Execution \tWeight\tCallback Valid? test event \t0.000 sec\t 0\t N/A test event2 \t0.000 sec\t 0\t N/A .... OK (6) PASS: tests/testEvent ... OK (3) PASS: tests/testEventLoop PASS: tests/test_http_range ..... OK (5) PASS: tests/testHttpParser .SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). OK (1) PASS: tests/testHttpReply ............. OK (13) PASS: tests/testHttpRequest ........SKIP: cache_cf.cc operator void* (not implemented). ... OK (11) PASS: tests/testStore .... OK (4) PASS: tests/testString stub time| persistent connection module initialized .......... OK (10) PASS: tests/testURL . OK (1) PASS: tests/testConfigParser ... OK (3) PASS: tests/testStatHist .SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: StatHist.cc enumInit (not implemented). SKIP: tools.cc UsingSmp (not implemented). SKIP: tools.cc InDaemonMode (not implemented). .SKIP: tools.cc UsingSmp (not implemented). SKIP: tools.cc InDaemonMode (not implemented). SKIP: cache_cf.cc operator void* (not implemented). SKIP: tools.cc UsingSmp (not implemented). SKIP: tools.cc InDaemonMode (not implemented). SKIP: tools.cc UsingSmp (not implemented). SKIP: stub_store_rebuild.cc storeRebuildComplete (not implemented). SKIP: tools.cc InDaemonMode (not implemented). FSKIP: StatHist.cc count (not implemented). SKIP: StatHist.cc count (not implemented). SKIP: StatHist.cc count (not implemented). SKIP: StatHist.cc count (not implemented). SKIP: StatHist.cc count (not implemented). SKIP: StatHist.cc count (not implemented). testRock.cc:240:Assertion Test name: testRock::testRockSwapOut assertion failed - Expression: pe->swap_status == SWAPOUT_WRITING Failures !!! Run: 2 Failure total: 1 Failures: 1 Errors: 0 FAIL: tests/testRock .SKIP: cache_cf.cc operator void* (not implemented). SKIP: stub_store_rebuild.cc storeRebuildComplete (not implemented). . OK (2) PASS: tests/testUfs PASS: testHeaders ================================================= 1 of 18 tests failed Please report to http://www.squid-cache.org/bugs/ ================================================= make[5]: *** [check-TESTS] Error 1 make[5]: Leaving directory `<http://build.squid-cache.org/job/3.HEAD-amd64-opensuse/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'> make[4]: *** [check-am] Error 2 make[4]: Leaving directory `<http://build.squid-cache.org/job/3.HEAD-amd64-opensuse/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'> make[3]: *** [check-recursive] Error 1 make[3]: Leaving directory `<http://build.squid-cache.org/job/3.HEAD-amd64-opensuse/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'> make[2]: *** [check] Error 2 make[2]: Leaving directory `<http://build.squid-cache.org/job/3.HEAD-amd64-opensuse/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'> make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory `<http://build.squid-cache.org/job/3.HEAD-amd64-opensuse/ws/btlayer-00-default/squid-3.HEAD-BZR/_build'> make: *** [distcheck] Error 1 buildtest.sh result is 2 BUILD: .././test-suite/buildtests/layer-00-default.opts configure: BUILD LIBRARIES: configure: BUILD EXTRA LIBRARIES: -lm -lnsl -lresolv -lcap -lrt -ldl -ldl configure: BUILD OBJECTS: configure: BUILD EXTRA OBJECTS: configure: BUILD C FLAGS: -Wall -g -O2 configure: BUILD EXTRA C FLAGS: -Wall -Wpointer-arith -Wwrite-strings -Wmissing-prototypes -Wmissing-declarations -Wcomments -Werror -pipe -D_REENTRANT configure: BUILD C++ FLAGS: -g -O2 -std=c++0x configure: BUILD EXTRA C++ FLAGS: -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT configure: BUILD LIBRARIES: configure: BUILD EXTRA LIBRARIES: -lm -lnsl -lresolv -lcap -lrt -ldl -ldl configure: BUILD OBJECTS: configure: BUILD EXTRA OBJECTS: configure: BUILD C FLAGS: -Wall -g -O2 configure: BUILD EXTRA C FLAGS: -Wall -Wpointer-arith -Wwrite-strings -Wmissing-prototypes -Wmissing-declarations -Wcomments -Werror -pipe -D_REENTRANT configure: BUILD C++ FLAGS: -g -O2 -std=c++0x configure: BUILD EXTRA C++ FLAGS: -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT checking for egrep... .././test-suite/../configure: line 6880: echo: write error: Broken pipe checking for fgrep... .././test-suite/../configure: line 7778: echo: write error: Broken pipe checking for fgrep... ../configure: line 7778: echo: write error: Broken pipe assertion failed FAIL: tests/testRock make[5]: *** [check-TESTS] Error 1 make[4]: *** [check-am] Error 2 make[3]: *** [check-recursive] Error 1 make[2]: *** [check] Error 2 make[1]: *** [check-recursive] Error 1 make: *** [distcheck] Error 1 Build FAILED. Build step 'Execute shell' marked build as failure
