See 
<http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/272/changes>

Changes:

[Amos Jeffries] Do not check 'reply content_length is too big' condition twice.

Saves a few CPU cycles. No visible runtime effects are expected.

The semi-duplicate check was introduced in trunk r4410 while trying to
prevent huge objects from being swapped out. It is not clear to me why
that change helped at the time (but it could have something to do with
negative content_length values and their effect on then-current size
types).

------------------------------------------
[...truncated 6920 lines...]
Testing ../../src/HttpVersion.h ...Ok.
Testing ../../src/HttpRequest.h ...Ok.
Testing ../../src/FileMap.h ...Ok.
Testing ../../src/ConfigParser.h ...Ok.
Testing ../../src/client_side.h ...Ok.
Testing ../../src/StoreMeta.h ...Ok.
Testing ../../src/SquidMath.h ...Ok.
Testing ../../src/LeakFinder.h ...Ok.
Testing ../../src/DelayIdComposite.h ...Ok.
Testing ../../src/CacheManager.h ...Ok.
Testing ../../src/CpuAffinitySet.h ...Ok.
Testing ../../src/URLScheme.h ...Ok.
Testing ../../src/MemBuf.h ...Ok.
Testing ../../src/DelayId.h ...Ok.
Testing ../../src/BodyPipe.h ...Ok.
Testing ../../src/HttpReply.h ...Ok.
Testing ../../src/StatHist.h ...Ok.
Testing ../../src/HttpHeaderStat.h ...Ok.
Testing ../../src/mem_node.h ...Ok.
Testing ../../src/DelayPool.h ...Ok.
Testing ../../src/StoreMetaObjSize.h ...Ok.
Testing ../../src/helper.h ...Ok.
Testing ../../src/errorpage.h ...Ok.
Testing ../../src/ClientInfo.h ...Ok.
Testing ../../src/HttpStatusLine.h ...Ok.
Testing ../../src/StoreIOBuffer.h ...Ok.
Testing ../../src/LoadableModule.h ...Ok.
Testing ../../src/typedefs.h ...Ok.
Testing ../../src/ipcache.h ...Ok.
Testing ../../src/comm_err_t.h ...Ok.
Testing ../../src/clientStream.h ...Ok.
Testing ../../src/FadingCounter.h ...Ok.
Testing ../../src/client_side_request.h ...Ok.
Testing ../../src/Mem.h ...Ok.
Testing ../../src/HttpHdrCc.h ...Ok.
Testing ../../src/htcp.h ...Ok.
Testing ../../src/StoreSearch.h ...Ok.
Testing ../../src/pconn.h ...Ok.
Testing ../../src/CpuAffinity.h ...Ok.
Testing ../../src/Generic.h ...Ok.
Testing ../../src/ETag.h ...Ok.
Testing ../../src/CpuAffinityMap.h ...Ok.
Testing ../../src/MemObject.h ...Ok.
Testing ../../src/SwapDir.h ...Ok.
Testing ../../src/ClientRequestContext.h ...Ok.
Testing ../../src/HelperChildConfig.h ...Ok.
Testing ../../src/StoreMetaUnpacker.h ...Ok.
Testing ../../src/err_detail_type.h ...Ok.
Testing ../../src/cbdata.h ...Ok.
Testing ../../src/lookup_t.h ...Ok.
Testing ../../src/snmp_core.h ...Ok.
Testing ../../src/URL.h ...Ok.
Testing ../../src/wordlist.h ...Ok.
Testing ../../src/StoreFileSystem.h ...Ok.
Testing ../../src/AccessLogEntry.h ...Ok.
Testing ../../src/ConfigOption.h ...Ok.
Testing ../../src/CommCalls.h ...Ok.
Testing ../../src/PeerSelectState.h ...Ok.
Testing ../../src/EventLoop.h ...Ok.
Testing ../../src/forward.h ...Ok.
Testing ../../src/DelayPools.h ...Ok.
Testing ../../src/ChunkedCodingParser.h ...Ok.
Testing ../../src/Store.h ...Ok.
Testing ../../src/StoreMetaMD5.h ...Ok.
Testing ../../src/enums.h ...Ok.
Testing ../../src/HttpHeaderMask.h ...Ok.
Testing ../../src/StoreIOState.h ...Ok.
Testing ../../src/TimeOrTag.h ...Ok.
Testing ../../src/DelayConfig.h ...Ok.
Testing ../../src/hier_code.h ...Ok.
Testing ../../src/DelayUser.h ...Ok.
Testing ../../src/HttpParser.h ...Ok.
Testing ../../src/MemBlob.h ...Ok.
Testing ../../src/HttpStatusCode.h ...Ok.
Testing ../../src/icp_opcode.h ...Ok.
Testing ../../src/HttpHdrContRange.h ...Ok.
Testing ../../src/SquidDns.h ...Ok.
Testing ../../src/globals.h ...Ok.
Testing ../../src/DelayVector.h ...Ok.
Testing ../../src/http.h ...Ok.
Testing ../../src/HttpHdrScTarget.h ...Ok.
Testing ../../src/SquidTime.h ...Ok.
Testing ../../src/PingData.h ...Ok.
Testing ../../src/Parsing.h ...Ok.
Testing ../../src/HttpBody.h ...Ok.
Testing ../../src/StoreMetaSTD.h ...Ok.
Testing ../../src/event.h ...Ok.
Testing ../../src/DescriptorSet.h ...Ok.
Testing ../../src/comm.h ...Ok.
Testing ../../src/DelayBucket.h ...Ok.
Testing ../../src/LoadableModules.h ...Ok.
Testing ../../src/stmem.h ...Ok.
Testing ../../src/CommRead.h ...Ok.
Testing ../../src/CompositePoolNode.h ...Ok.
Testing ../../src/Server.h ...Ok.
Testing ../../src/DelayTagged.h ...Ok.
Testing ../../src/swap_log_op.h ...Ok.
Testing ../../src/HierarchyLogEntry.h ...Ok.
Testing ../../src/StoreClient.h ...Ok.
Testing ../../src/structs.h ...Ok.
Testing ../../src/client_side_reply.h ...Ok.
Testing ../../src/StoreMetaSTDLFS.h ...Ok.
Testing ../../src/defines.h ...Ok.
Testing ../../src/HttpHeaderTools.h ...Ok.
Testing ../../src/RemovalPolicy.h ...Ok.
Testing ../../src/Packer.h ...Ok.
Testing ../../src/DelaySpec.h ...Ok.
Testing ../../src/AsyncEngine.h ...Ok.
Testing ../../src/CompletionDispatcher.h ...Ok.
Testing ../../src/StoreSwapLogData.h ...Ok.
Testing ../../src/DiskIO/ReadRequest.h ...Ok.
Testing ../../src/DiskIO/DiskIOModule.h ...Ok.
Testing ../../src/DiskIO/DiskIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskFile.h ...Ok.
Testing ../../src/DiskIO/WriteRequest.h ...Ok.
Testing ../../src/DiskIO/IORequestor.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedFile.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedIOStrategy.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskFile.h ...Ok.
Testing ../../src/DiskIO/AIO/async_io.h ...Ok.
Testing ../../src/DiskIO/AIO/aio_win32.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskIOModule.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskFile.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/CommIO.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreads.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoFile.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdFile.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/diomsg.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdAction.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingIOStrategy.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingFile.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingDiskIOModule.h ...Ok.
..
OK (2)
PASS: tests/testACLMaxUserIP
.
OK (1)
PASS: tests/testBoilerplate
..
OK (2)
PASS: tests/testCacheManager
.
OK (1)
PASS: tests/testDiskIO
..Actual Text:
Last event to run: last event

Operation                \tNext Execution \tWeight\tCallback Valid?
test event               \t0.000 sec\t    0\t N/A
test event2              \t0.000 sec\t    0\t N/A

....
OK (6)
PASS: tests/testEvent
...
OK (3)
PASS: tests/testEventLoop
PASS: tests/test_http_range
.....
OK (5)
PASS: tests/testHttpParser
.
OK (1)
PASS: tests/testHttpReply
.............
OK (13)
PASS: tests/testHttpRequest
Not implementedNot implementedNot implementedNot implementedNot implementedNot 
implementedNot implementedNot implementedNot implementedNot implementedNot 
implementedNot implementedNot implementedNot implementedNot implementedNot 
implementedNot implementedNot implementedNot implementedNot implementedNot 
implementedNot implementedNot implementedNot implementedNot implementedNot 
implemented...........
OK (11)
PASS: tests/testStore
....
OK (4)
PASS: tests/testString
stub time| persistent connection module initialized
..........
OK (10)
PASS: tests/testURL
.
OK (1)
PASS: tests/testConfigParser
...
OK (3)
PASS: tests/testStatHist
Not implementedNot implementedNot implementedNot implementedNot implementedNot 
implementedNot implementedNot implementedNot implementedNot implementedNot 
implementedNot implemented..F
testRock.cc:236:Assertion
Test name: testRock::testRockSwapOut
assertion failed
- Expression: pe->swap_status == SWAPOUT_WRITING

Failures !!!
Run: 2   Failure total: 1   Failures: 1   Errors: 0
FAIL: tests/testRock
Not implementedNot implemented..
OK (2)
PASS: tests/testUfs
PASS: testHeaders
=================================================
1 of 18 tests failed
Please report to http://www.squid-cache.org/bugs/
=================================================
make[5]: *** [check-TESTS] Error 1
make[5]: Leaving directory 
`<http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/ws/btlayer-00-default/squid-3.2.2-BZR/_build/src'>
make[4]: *** [check-am] Error 2
make[4]: Leaving directory 
`<http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/ws/btlayer-00-default/squid-3.2.2-BZR/_build/src'>
make[3]: *** [check-recursive] Error 1
make[3]: Leaving directory 
`<http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/ws/btlayer-00-default/squid-3.2.2-BZR/_build/src'>
make[2]: *** [check] Error 2
make[2]: Leaving directory 
`<http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/ws/btlayer-00-default/squid-3.2.2-BZR/_build/src'>
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory 
`<http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/ws/btlayer-00-default/squid-3.2.2-BZR/_build'>
make: *** [distcheck] Error 1
buildtest.sh result is 2
BUILD: .././test-suite/buildtests/layer-00-default.opts
configure: BUILD LIBRARIES: 
configure: BUILD EXTRA LIBRARIES: -lm -lnsl -lresolv -lcap -lrt -ldl -ldl
configure: BUILD OBJECTS: 
configure: BUILD EXTRA OBJECTS: 
configure: BUILD C FLAGS: -Wall -g -O2
configure: BUILD EXTRA C FLAGS: -Wall -Wpointer-arith -Wwrite-strings 
-Wmissing-prototypes -Wmissing-declarations -Wcomments -Werror -pipe 
-D_REENTRANT
configure: BUILD C++ FLAGS: -g -O2
configure: BUILD EXTRA C++ FLAGS: -Wall -Wpointer-arith -Wwrite-strings 
-Wcomments -Werror -pipe -D_REENTRANT
configure: BUILD LIBRARIES: 
configure: BUILD EXTRA LIBRARIES: -lm -lnsl -lresolv -lcap -lrt -ldl -ldl
configure: BUILD OBJECTS: 
configure: BUILD EXTRA OBJECTS: 
configure: BUILD C FLAGS: -Wall -g -O2
configure: BUILD EXTRA C FLAGS: -Wall -Wpointer-arith -Wwrite-strings 
-Wmissing-prototypes -Wmissing-declarations -Wcomments -Werror -pipe 
-D_REENTRANT
configure: BUILD C++ FLAGS: -g -O2
configure: BUILD EXTRA C++ FLAGS: -Wall -Wpointer-arith -Wwrite-strings 
-Wcomments -Werror -pipe -D_REENTRANT
checking for egrep... .././test-suite/../configure: line 6643: echo: write 
error: Broken pipe
checking for fgrep... .././test-suite/../configure: line 7541: echo: write 
error: Broken pipe
assertion failed
FAIL: tests/testRock
make[5]: *** [check-TESTS] Error 1
make[4]: *** [check-am] Error 2
make[3]: *** [check-recursive] Error 1
make[2]: *** [check] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [distcheck] Error 1
Build FAILED.
Build step 'Execute shell' marked build as failure

Reply via email to