Merged, and hit a snag which I hadn't met in testing. In order to define whether the level of the message requires displaying the file contents, I tried to use preprocessor-available information. In that way, if the level is high, it'd be compiled out: very efficient on the critical path. But this requires that the debug level be constant, and it is not the case with DBG_PARSE_NOTE.
In order to fix immediately the issue I'll refer to Debug::level in debugs() instead which is runtime-determined, but I wonder if it'd be worth to change the 160-ish references of DBG_PARSE_NOTE so that it is statically-defined as well.. On Sat, Nov 10, 2012 at 4:58 PM, Kinkie <[email protected]> wrote: > Will fix before applying. Thanks. > > On Sat, Nov 10, 2012 at 4:47 PM, Amos Jeffries <[email protected]> wrote: >> On 11/11/2012 3:57 a.m., Kinkie wrote: >>> >>> Hi all, >>> here's the promised patch. It's actually even simpler than what Alex >>> was suggesting. Run-tested. >> >> >> +1 from me. Although the TODO should be "before 3.4" (not 3.3). >> >> Amos > > > > -- > /kinkie -- /kinkie
