On 29.11.2012 12:07, Henrik Nordström wrote:
While trying to set up an advanced Squid-3.2.3 with 4 workers, a
number
of rock stores for different objects and per-worker aufs caches for
larger files I ran into multiple issues.
<snip>
- cache.log completely flooded with memset() messages at startup with
full debug enabled.
<snip>
--- squid-3.2.3/src/ipc/StoreMap.cc 2012-10-20 15:39:49.000000000
+0300
+++ squid-3.2.3/src/ipc/StoreMap.cc 2012-11-20 20:55:41.089500435
+0200
@@ -272,8 +272,8 @@
Ipc::StoreMapSlot::StoreMapSlot(): state(Empty)
{
- xmemset(&key, 0, sizeof(key));
- xmemset(&basics, 0, sizeof(basics));
+ memset(&key, 0, sizeof(key));
+ memset(&basics, 0, sizeof(basics));
}
Does anybody know the rationale for having xmemset at all?
Should we drop it completely from the code and reduce the dependencies
for some code a bit?
or should we shuffle it into the leakfinder or profiler code as a
#define?
Either way IMO it looks like we should drop the 'x' version from the
rest of the code base by default.
Amos
