On 12/13/2012 12:45 AM, Amos Jeffries wrote: >> I think the USE_SSL exist in all places required. >> If there is not any objection: >> - I will move the LruMap under the src/base directory >> - I will apply this patch >> - I will remove with a second patch all "#if 1 //USE_SSL_CERT_VALIDATOR" >> > > I do object. The last two steps are adding useless patches. Please > remove the conditionals *before* applying to trunk.
No problem, makes no difference to me. Regards, Christos > >> >>> PS. Christos, can you please avoid even developing with the "#if 1 // >>> USE_BLAH" style of force-enabling. If it is worth putting the >>> conditionals in at all it is worth adding a ./configure option and >>> testing during development with that options set/unset. >> >> In this project I use it as a comment. Something like "//Here starts >> cert validator code" and "//here stops the cert validator code". >> There are cases inside squid where we have similar blocks of code inside >> "#if 1" or "#if 0". >> For this project it is not worth such configure option. >> I agree it may confuse other developers, so it is better to just remove >> it... >> > > OK. > > > Amos > >
