On 01/02/2013 05:05 PM, Amos Jeffries wrote: > On 3/01/2013 5:13 a.m., Alex Rousskov wrote: >> On 12/29/2012 12:16 AM, Eliezer Croitoru wrote: >>> + /** >>> + * a copy of request->store_id which needed in couple places >>> where the request >>> + * cannot be accessed or dosnt exists. >>> + */ >>> + String store_id; >> This description does not make sense to me. If request does not exist >> (i.e., the request member is nil), there cannot be a copy of >> request->store_id. And if it exists, then it can be accessed without >> making a copy. > > There is the case of internal objects such as icons. Which during > loading need to have a store_id and all the infrastructure for adding to > cache but no request. > There is also ICP requests which need to oeprate without any HttRequest > state.
Yes, I know, but request-less transactions do not make the description correct AFAICT because, when there is no request, the stored value is not a copy of request->store_id. Cheers, Alex.
