On 8/02/2013 10:07 p.m., Tianyin Xu wrote:
It's not wrong but when I see the code I want to refine it since it looks uncomfortable.

 680     if (Config.Announce.period > 0) {
 681         Config.onoff.announce = 1;
 682     } else if (Config.Announce.period < 1) {
 683         Config.Announce.period = 86400 * 365;   /* one year */
 684         Config.onoff.announce = 0;
 685     }

Announce.period is with type "time_t" so it's an integer. The "else-if" is "logically" superfluous because as long as the value <=0, it must be <1.


+1 and applied to trunk. Thank you.

Amos

Reply via email to