On 05/10/2013 11:40 PM, Amos Jeffries wrote: > On 11/05/2013 10:24 a.m., Alex Rousskov wrote: >> Hello, >> >> The attached patch fixes a memory leak related to parsing >> configurable SSL error details. >> >> Trunk r11496 "Configurable SSL error details messages" correctly >> disabled collection of HTTP statistics for non-HTTP header fields, such >> as configurable SSL error details. However, it also incorrectly disabled >> deletion of those non-HTTP header fields. >> >> Configurable SSL error details are only created during [re]configuration >> time, so the leak went unnoticed since 2011-06-17. However, when >> annotations were added to non-HTTP header fields (r12413), the old bug >> resulted in a major leak for configurations that annotate transactions. >> >> Fortunately, that major leak was removed by r12779 "helperNotes to >> NotePairs" polishing, which stopped using HttpHeader for annotations. >> However, any code based on trunk between r12413 and r12779 needs this >> fix (or needs to be resynced with the current trunk).
> What do you mean by this? do we have the problem in 3.3 / 3.2 or not? Yes, we do, but not a major one. AFAIK, both v3.3 and v3.2 have a leak that the proposed patch fixes (hoErrorDetail). AFAIK, neither v3.3 nor v3.2 have a major leak because they do not support HttpHeader-based annotations (hoNote). HTH, Alex.
