On Tue, May 28, 2013 at 3:19 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 28/05/2013 8:09 p.m., Kinkie wrote: >> >> Hi, >> this patch (minus the formatting, I will commit directly to trunk if >> approved) fixes the build on Intel's compiler suite. >> Summary of changes: >> - change configure to not define _FILE_OFFSET_BITS=64 on 64+bit >> platforms - it's not needed and it confuses libg++. To do this I need >> to detect sizeof(long) early; it's a double check but I don't feel we >> need to restructure the whole configure.ac for one single check > > > You could cache it and re-use the cached result on the second check if it > matters.
Caching is already done by the macro. >> - #if-guard some gcc-specific #pragma directives so that they're not used >> on icc >> > > It looks okay to me. > > +1 regardless of whether you choose to do the cache tweak. Ok, thanks. Committing. Kinkie
