On 11/14/2013 02:48 PM, Kinkie wrote: > It compiles and worksforme, no regressions are introduced by this that > I could notice. > I'll schedule a test farm run, and if it works, apply.
Personally, I do not think the commit bar has to be that high for this change. As far as I am concerned, please feel free to commit without a test farm run and monitor the results. Thank you, Alex. > On Thu, Nov 14, 2013 at 6:09 PM, Alex Rousskov > <rouss...@measurement-factory.com> wrote: >> On 11/13/2013 10:34 AM, Kinkie wrote: >>> Hi, >>> a few functions were missing from stub_mem.cc which prevented it >>> from being effecitve. >>> By affording to waste memory in the unit tests, they can be >>> implemented very simply, and I've done just that in the attached >>> patch. >>> The eventual goal is to reduce the number of object files needed for unit >>> tests. >> >> I cannot validate Makefile changes, but the memory wasting approach >> sounds good to me. >> >> >> Thank you, >> >> Alex. >> >> >> > > >
