>>> in src/SBufDetailedStats.cc >>> * please name the namespace >> >> What is the benefit? The code in there is just in order to have the >> post-init stuff done in StatHist, it's not meant to be seen anywhere >> else (so the anonymous namespace is really intentional). Not a big >> deal, but I'm curious. > > It will save on getting doxygen confused. And if we ever need to > reference inside that scope or add bits to it the namespace name > provides a hint as to what might be appropriate use.
Ok, fair enough. I will add a name to it. Once that's done, may I submit? (btw: that post-init code is the result of StatHist C-ness, it should go away, I'd vebture by subclassing and polymorphism) Thanks -- /kinkie