On 14/12/2013 11:17 p.m., Francesco Chemolli wrote: > Francesco Chemolli has proposed merging lp:~squid/squid/sbuflist-merge into > lp:squid. > > Requested reviews: > squid (squid) > > For more details, see: > https://code.launchpad.net/~squid/squid/sbuflist-merge/+merge/199024 >
in src/SBufAlgos.h: * SBufAddLength::separator_len does not meet camelCase_ private member naming guideline. * the if(sz == 0) and comment do not match up. - I suspect it should probably be a check on items.size() to match the comment and the whole if() be done before the sz accumulate is attempted. * #includes block is inconsistent with rest of Squid which places empty line between "local" and <system> include statements. in src/SBufList.cc: * the #include SBufAlgos.h should be sorted before SBufList.h * #include wordlist.h seems not needed. Yes? Thank you. These are all minor so no need for another review after fixing. Amos
