Hi
I can't create the pull request, returns the message "Pull request creation failed. Validation failed: must be a collaborator"


On 2026-03-05 2:40 p.m., Alex Rousskov wrote:
On 2026-03-04 17:44, Andre Bolinhas wrote:

The |proxy_auth -i| ACL (case-insensitive user matching) is broken in Squid 6.x.

Yes, there are several bugs/problems there. See a long comment above Acl::Option class declaration for how things are supposed to work.

If you can volunteer to work on a fix, please post a pull request as discussed at https://wiki.squid-cache.org/MergeProcedure#pull-request

In that pull request, instead of Option A and Option B, please do this:

1. Split ACLUserData::userDataNames into two sets: caseSensitiveNames and caseInsensitiveNames. Add tokens to the right set, depending on the current CaseInsensitive_ value. Search/print both sets as needed. Remove flags.case_insensitive.

2. Ignore any '-i' and '+i' tokens in ACLUserData::parse(), with a level-1 warning, instead of adding them to a set as if they were user names.

3. Check other ACLs that use lineOptions() for similar bugs.


Thank you,

Alex.
P.S. I am sorry that our Bugzilla is still down, preventing you from using it to report this bug. We can continue to discuss this on GitHub.
_______________________________________________
squid-users mailing list
[email protected]
https://lists.squid-cache.org/listinfo/squid-users

Reply via email to