On 06/02/2010 08:54 AM, Silamael wrote:
> Hello!
> 
> Yesterday i tried to build the new version of Squid on OpenBSD 4.6.
> Unfortunately there's some problem in src/mem.cc. new_pool_limit is of
> type size_t which is a long unsigned int. In line 359 a -1 is written
> into new_pool_limit. Newer g++ versions seems to accept this as valid
> but OpenBSD's g++ 3.3.5 complains about it.
> Attached is a small patch to fix this.
> 
> PS: Your bugzilla site seems to be down at moment. I'm just getting some
> Perl error messages.
> 
> -- Matthias

Further looked into this and for me it now just seems to be a typo.
In MemPools::setIdleLimit the argument type is ssize_t.
The new patch attached should fix this properly.

-- Matthias
Seems to be a typo. In setIdleLimit the limit value is a ssize_t.
Newer versions of gcc do not complain about this but OpenBSD's gcc does.

--- src/mem.cc.orig     Wed Jun  2 12:10:25 2010
+++ src/mem.cc  Wed Jun  2 12:10:41 2010
@@ -346,7 +346,7 @@
 void
 memConfigure(void)
 {
-    size_t new_pool_limit;
+    ssize_t new_pool_limit;
 
     /** Set to configured value first */
     if (!Config.onoff.mem_pools)

Reply via email to