I see a module with a rather obvious scope to it, that will probably accommodate the majority of users. Within that scope it works well. I can't see calling it broken just because it doesn't work exactly the way I may want.
And yes, I would consider anything that falls outside that scope to be a feature request. If something isn't a 100% fit, you have a 90% solution ready for customization. If it really doesn't default to a reasonable path for squidguard.conf, then yes, I would consider that a bug. I had to change it, but just assumed it was a FreeBSD/Linux hierarchy difference. There were other changes I made as well, but I wouldn't consider them general enough to be eligible for public distribution. Everything else mentioned are design choices I can understand. The "bl_" is a good example. It allows for the one-click "enable/disable this list" while minimizing risk it will trounce on my hand edited destination groups. A reasonable compromise IMO. For the record, I am in no way affiliated with either squidguard or the webmin module. Just a contented user. I have no doubt that a year from now, the module will address most of the issues raised, like most other Open Source solutions it will probably be an always evolving work-in-progress. If functionality is needed on something other that the author's schedule, the code is there ready to be customized. Jerry ----- Original Message ----- From: "Morris Maynard" <[EMAIL PROTECTED]> To: "Squidguard Mailing List" <[EMAIL PROTECTED]> Sent: Wednesday, November 07, 2001 7:52 AM Subject: RE: squidGuard Module for Webmin > No, it's broken. > The assumption of a path to the squidguard.conf file that differs from the > path in the sample config file that comes with squidguard means that the > module will not work with the already running squidguard that 95% of people > have when the first try to use the module. > > The forced addition of "bl_" to all of the destination blocks (and ignoring > any blocks that don't start with those characters) is an additional and > unneccesary layer of confusion. > > I thought that "It's not a bug, it's an unimplemented feature" was supposed > to be a joke. > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Jerry Murdock > Sent: Wednesday, November 07, 2001 2:02 AM > To: Squidguard Mailing List > Subject: Re: squidGuard Module for Webmin > > > But the problems aren't really problems, IMO. They could at some point be > considered feature requests. > > The module has to make some assumptions to put some structure around the > relatively amorphous squidguard.conf file. It really makes only one - that > you are using the module as your primary management tool. > > If 5 minutes had been taken to make some changes and see the results in the > .conf file the light would have come on. It still may not be a fit, but so > what? Log a feature request/suggestion, but don't imply it is broken. > > I agree that it is not a 100% be-all solution, but it certainly isn't > broken, > especially within the bounds of the issues raised. > > Just my thoughts, > > Jerry > > ----- Original Message ----- > From: "Joe Cooper" <[EMAIL PROTECTED]> > To: "Rick Matthews" <[EMAIL PROTECTED]> > Cc: "Squidguard Mailing List" <[EMAIL PROTECTED]> > Sent: Wednesday, November 07, 2001 12:18 AM > Subject: Re: squidGuard Module for Webmin > > > > Hi Rick, > > > > Have you mentioned any of this to Tim? (The fellow who wrote it for us, > > and has been working on enhancements and bugfixes for another company > > recently. It will see quite a bit more work from Swell pretty soon as > > well, as we will be integrating SquidGuard into our systems soon.) > > > > The module isn't perfect yet, but Tim really does try hard to make it > > work well by the time he calls it 'stable'. It is still in beta right > > now, so the point is to find these problems and get them fixed--not > > expect it to 'just work' out of the box. Nonetheless it is the only GUI > > I know of that will address all of the various aspects of SquidGuard > > administration (adding|removing|viewing the db, setting up the access > > groups and rules, etc.). > > > > Just a thought... > > > > Rick Matthews wrote: > > > > > Well, I answered my own question by looking through his cgi scripts in > > > </usr/libexec/webmin/squidguard>. > > > > > > The author has made the assumption that your blacklists are in: > > > > > > <$dbhome/blacklists/porn> > > > <$dbhome/blacklists/ads> > > > etc. > > > > > > This assumption is contrary to the documentation, which says: > > > domainlist filename > > > where: filename is either a path relative to dbhome or an absolute path > > > (i.e. /full/path) to a database file. > > > > > > So, the following combination works with squidGuard and conforms to the > > > documentation: > > > dbhome /usr/local/squidGuard/db > > > domainlist block/blacklist/porn/domains > > > full path /usr/local/squidGuard/db/block/blacklist/porn/domains > > > > > > The above combination does not work with the Webmin squidGuard module, > > > however, due to the author's incorrect assumption concerning the path. > > > > > > Since I've been very interested in seeing what the squidGuard module > > > does for you, I made a few changes so that my path declarations would > > > conform to the author's assumptions. After bouncing squid I tried the > > > squidGuard module again. > > > > > > This time the blacklists option opened to show an icon for each of my > > > blacklist categories (porn, ads, etc.) Clicking on the icon apparently > > > causes the module to completely read the blacklist before opening a page > > > that allows you to search or add to the files. Clicking on <porn> caused > > > a delay of 20 - 25 seconds before presenting the next screen; clicking > > > on <ads> brought up the next screen in less than a second. > > > > > > I guess the last straw was that in each of the categories, the search > > > page had a red notice at the top that said "This blacklist is disabled". > > > There is also a link labeled "Enable this blacklist". I have no idea > > > why the module thinks my blacklists are disabled, but at this point I > > > don't really care. > > > > > > I've uninstalled the squidGuard module for Webmin. > > > > -- > > Joe Cooper <[EMAIL PROTECTED]> > > http://www.swelltech.com > > Web Caching Appliances and Support > > > > > >
