Hello Raytodd,
On Thursday, December 12, 2002, [EMAIL PROTECTED] wrote...

> I finally found the bug in the code that I have bee commenting on.
> Specifically on linux apache php 4.1.x (yes I will be upgrading)
> WHen I log in and mistype the user id and pass word in addition to
> the squirrel mail error message I get a php error.

  What is the error message you get?

> The orginal code in sqm_topdir in display_messages.php seemed to be
> the problem. It appears that in this case if a file of some name
> doesn't exist and you try and check if it is a directory you have a
> problem. The following code change seems to make the error go away.
> I can't see how it might break something.

  It could end up setting sqm_topdir() to a filename instead of a
  folder, which would result in the config files not being opened, and
  causing further errors when a login fails. The only reason I see
  that function exists is in the logout error message, which displays
  an error message, and the company logos (if changed). The quote on
  the is_dir from php is:

,----- [ http://www.php.net/manual/en/function.is-dir.php ]
| Returns TRUE if the filename exists and is a directory. If filename
| is a relative filename, it will be checked relative to the current
| working directory.
`-----

  This suggests that if the file doesn't exist, or it is not a folder,
  it returns false.

> How does one bring this to the developer's attention?

  You did :)

-- 
Jonathan Angliss
([EMAIL PROTECTED])



-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/
--
squirrelmail-users mailing list
List Address: [EMAIL PROTECTED]
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Reply via email to