Eric Dry zei: >> Hello Eric, >> >> We do not add this to the 1.2.x because 1.4 is the next stable version. >> However due to the changed architecture of some parts in 1.4 it was very >> easy to add extra header checks for the 2 mentioned headers. >> I added those checks to the 1.4 branche. >> >> Note: The way you request the extra headers is timeconsuming because it >> requires 2 extra imap-calls. In SM 1.4 we need 1 call (only for the full >> rfc822-header) and we look for known headerfields and process them. >> Adding your proposed search for the headerfields X-Confirm-Reading-To >> and Return-Receipt-To does not influence the performance in 1.4 (not >> significant). >> >> I advise you to checkout the cvs or wait for the cvs snapshot with >> todays changes and try that version. Your bosses will be very happy :-) >> >> Regards, >> >> >> Marc Groot Koerkamp. >> > > Thanks Marc, > > I would love to see how it _should_ have been done. I was under a time > limit and knew you guys would probably have a better way to do it, > unfortunately I was on my own with this one. Glad to have helped!
The fix for the SM 1.4 branche was realy easy and only possible due to some of the architecture changes in the develbranche. For the 1.2.x branche it's not so easy to do. So don't worry about 1.2.x and see the changes in class/mime/Rfc822Header.class.php. The way how it should be implemented is limit the number of imap-calls by fetching the full rfc822 header and parse the results. Only problem is that there were many places in SM 1.2.x where multiple imap-calls are used where 1 was sufficient. So in the light of the rest of the 1.2.x code the sollution you came with was a logical sollution. The reason I mentioned it was because I spend a lot of time to reducing the number of imap-calls in the 1.3 branche to gain performance and wanted to make a point that imap-calls are expensive. Anyway, thnx again for the header information, it will make pine users very happy :-) Marc. ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com -- squirrelmail-users mailing list List Address: [EMAIL PROTECTED] List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=2995 List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
