> Imagine my surprise while trying to add a copy button similar to the > move button to find that sqimap_msgs_list_copy() does not copy messages, > it moves them. IMHO, this badly violates the principle of least > surprise. If anyone is interested, I'll post the patches to the list > when I'm satisfied the code is stable.
Yep, you're right. That's a badly named function, at best. I see two possible solutions. Idea 1 ------ Copy sqimap_msgs_list_copy() to sqimap_msgs_list_move() and remove the delete command from sqimap_msgs_list_copy(). Update all existing references to sqimap_msgs_list_copy to point to the new _move() command. Idea 2 ------ Add a parameter to sqimap_msgs_list_copy(). If set, it deletes the messages after copying. I prefer the first solution, since it makes the purpose clearer. The second idea makes maintaining the code a little easier, in theory anyway. Unless someone gives me a good reason otherwise, I will be implementing Idea 1 in devel CVS. Jon, could you please give me the Official Word on if I can also add that to stable CVS? The thought of changing the API like this between stable releases makes my butt pucker.. -- Chris Hilts [EMAIL PROTECTED] ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 -- squirrelmail-users mailing list List Address: [EMAIL PROTECTED] List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id)95 List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
