> Hi > As you suggestion i write the diff files of "patch" and publish it on > this ML .... > > As you say "How can you guarantee that you are only stripping off the > correct number of newlines? " > the solution is simple: I wrote an autogenerating php page "on the fly" > with download informations only, after, i redirect SM on it,in this > manner, i precisely define the content i write on download channel and > avoid strange "unpredictable" behaviours that can come out from other > sections of program ( plugins, etc ... ). At the end of download > temporary files are removed in order to avoid to fill directory with > useless files.In this manner, IMHO, SM appear to be less prone to these > "side effects" and, think, this patch to be considered as "version > independent" if you consider that it creates and destroy itself without > involve any part of SM. > Don't worry for multi user environment : temporary files are named with > session cookie value so, think, they are uniques and don't conflict > with various users downloads.Multiple download from same user > generating, of course, the same file name, but this isn't a problem: > user can download one file at once ... > > WARNING !!! : In a very ugly manner i've 'Hard coded' ( is a nightly > build ... ) a path to a directory that contains temporary working files > the path for my installation is '/var/www/webmail/data' so you MUST > change this with your own directory were squirrel user can write/read ( > for me user is : nobody/nobody ) this can be solved using a global > variable .... > > Thanks to you and other people that have send kindly suggestions to me...
1. You are inserting function (dumpheaders) that is already present in squirrelmail. Function is called SendDownloadHeaders and is present in mime.php Reuse the code. 2. You assume that data or temp directory is accessible from the web, don't use $data_dir configuration setting and complain about hardcoded path to data directory. 3. You assume that $session_name is set to default value (SMQSESSID) 4. You have disabled function that converts base64 or quoted_printable file names. instead of having strange codes like , you might have filename written in raw headers. you haven't checked 1.5.1cvs and 1.4.4cvs, which rewrote that part of code. In squirrelmail 1.4.3a decodeHeader function does not insert and you can disable insertion of   in plain text headers by setting only one option. I think one of suggestions asked you to check latest squirrelmail version. SquirrelMail 1.4.3 contains fixes for fread function changes in latest php versions. Are you sure that blanks were not inserted by unexpected fread behavior. -- Tomas ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ -- squirrelmail-users mailing list Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines List Address: [EMAIL PROTECTED] List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.user List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=2995 List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
