Jonathan Angliss wrote:
Hello Paul Lesneiwski,
On Thursday, June 16, 2005, you wrote:
6. calendar_sql_backend - Configured to local MySQL
7. compatibility
When I goto calender I get the following:-
Warning: retrieve_data(../config/config.php): failed to open stream:
No such file or directory in
/usr/share/squirrelmail/plugins/retrieveuserdata/ldap.php on line 32
This is probably a bug in that plugin. Change the line in
retrieveuserdata/setup.php that looks like this:
define(SM_PATH,"../");
To this:
if (!defined('SM_PATH')) define('SM_PATH', '../');
Shouldn't that be...
if (!defined('SM_PATH')) define('SM_PATH', '../../');
Well, actually both. :) The problem is that setup.php is included both
by page requests to files in the core /src dir, 99% of the time.
Although in all cases here, SM_PATH should be predefined. The only time
it should be ../../ is when the page request is to a custom file
provided by the plugin. In that case, that custom file itself ususally
defines SM_PATH as ../../ (I would argue it SHOULD ALWAYS do so)
So then the code in setup.php becomes unneeded EXCEPT as a compatibility
failsafe for using plugins with pre-1.4 versions of SM. In that case,
it has to be ../ as I suggested.
So I'd say it should be ../ and we should make it clear that any custom
pages in a plugin should explicitly and immediately define SM_PATH as
../../ (oh, and the one in setup.php should always be wrapped in a
conditional!)
Using ../ from the setup.php file (or in this case the error is in
ldap.php) would only take you to the plugins directory, which is why
there is an error.
Well, yah, the source of the error is unarguable for sure, but the point
is that authors should *always* wrap those defines in if (!defined()) to
avoid anything nasty and hard to track down...
Ralf, I hope you can make the change I suggested at the top, and it
wouldn't hurt to have a look at fixing a few other things to bring the
plugin into spec with the plugin requirements in doc/plugin.txt (moving
in future releases to doc/Development/plugin.txt
- paul
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
--
squirrelmail-users mailing list
Posting Guidelines:
http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
List Address: [email protected]
List Archives:
http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.user
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
