> >> > wm> Version 1.4.4 > >> > wm> Upgrading from older version the toggle all link at the bottom of > >> > wm> the page no longer causes a jump to the top of the page as well as > >> > wm> the toggling of all marks > >> > > >> > I noticed and missed that, too, but I assumed the change was > >> > intentional. Going to the top of the page doesn't have much to do > >> > with toggling everything, though it is quite often what I do next. > >> > > >> Well I normally go down my mailbox and check what I want to save, toggle > >> at the bottom and delete everything else. AFAIK everything I do after > >> the > >> toggle is at the top of the page so going back up works for me. > > > > IIRC, the old (desired?) behavior only works in some browsers. If it > > really is desired, the better fix IMO is to add an anchor at page top > > and focus on that after doing the toggle. > Ok, of course it worked on both IE and FireFox, which were the only two > browsers to which I have access. > > Ok there is an anchor tag already <a name="pagetop"></a> Is the problem > the use of the ancor tag # vs javascript() or the lack of a name with the > anchor tag? > i.e., <a href="#pagetop" onClick="CheckAllINBOX();">Toggle All</a> > ?
The problem is that not 100% of the browsers out there will respect the anchor after the onClick I think (although they SHOULD, so technically, just reverting back to what it was is probably good enough). Since it is a javascript action anyway, we can force focus to the anchor after checking the checkboxes and return false (although not necessary to return false if the link is doing the same thing) to be more safe IMO. I guess the question is why this was changed and if anyone really likes the change. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 -- squirrelmail-users mailing list Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines List Address: [email protected] List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.user List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id)95 List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
