Greetings list, Submitted in this email, for your testing, is the third (and by far the best) incarnation of my logindomainlist patch. This version has been packaged a bit differently from the 2 versions before it.
To apply the patch, simply unzip and untar it, then
execute something like the following:
patch sqwebmail-3.5.0.20030301/sqwebmail/sqwebmail.c < sqwebmail-3.5.0.20030303.patch
It's diffed against the sqwebmail-3.5.0.20030215 release,
but it works fine with the newer sqwebmail-3.5.0.20030301
release as well. (I've tested it.)
What's New?
-----------
Some changes and some fixes primarily. I believe one new
feature has been added, but that's it.
1.) First and foremost, this patch no longer uses the buggy
strtok() clib function to parse the logindomainlist file.
It now uses a clone of the BSD strsep() function, mystrsep(),
to accomplish the same thing, but in a much more predictable
manner. The mystrsep() function is almost identical to
the BSD strsep function as far as the prototype is concerned,
but the internals are VERY different. It uses strchr() to
do most of it's work.
2.) The '-' modifier has gone away. It has been replaced by the
ability to specify an empty first field, like so:
:mydomain.com:*
or
:mydomain.com:firstgroup
otherdomain.com:otherdomain.com:firstgroup
yetanother.com:yetanother.com:firstgroup
In the first example, if the domain part of the calling URL
matches 'mydomain.com', then NO hidden field is generated.
This is useful for specifying exceptions to a wildcard
record. (For system accounts and such)
In the second example, a drop down is displayed if the
calling URL is 'mydomain.com', 'otherdomain.com', or
'yetanother.com'. However, if the calling URL is
'mydomain.com', then NO default domain will be set in the
drop down. Again, this might be useful if you have system
accounts.
3.) Bug fix: The last patch WAS NOT legacy logindomainlist
compatible (but the one before it WAS). This new patch IS
legacy logindomainlist compatible. If you just need a basic
drop down without any default domains - you can have it.
4.) Comments! You can now add comments to your logindomainlist
file! To add a comment, insert a '#' character at the very
beginning of a line, then start commenting.
Also, this new patch has basic 'empty line' ignoring capability.
If the line doesn't have a ':' in it anywhere, and it's less
than 3 characters in length, the parser will ignore it.
This is good for separating records visually, and is probably
best used with the new commenting capability!
5.) This item isn't really new, but I thought I'd note it anyway:
I HAVE NOT removed the '@' modifier. I was contemplating it,
but I decided against it since it allows for limited IP based
matching. The '*' modifier does NOT match IPs. I think the
IP matching functionality might be extended in the future,
so I have decided to keep the '@' modifier.
Also, note that the '@' modifier is a bit faster to parse
than the '*' modifier, but it doesn't allow for wildcarding,
so it has somewhat limited usefulness.
6.) A few other minor parsing bugs were fixed, and hopefully no
new bugs were introduced. :)
Once again, don't forget to let the list know if you need
functionality not included in this patch! The worst that can
happen is that I'll say, "NO!"
If you wait until this patch is included in a release version
of sqwebmail to test it, you might not realize that you need
different functionality until it's too late!
TEST TEST TEST!
Thanks, and Happy Testing!
--
Jesse Guardiani, Systems Administrator
WingNET Internet Services,
P.O. Box 2605 // Cleveland, TN 37320-2605
423-559-LINK (v) 423-559-5145 (f)
http://www.wingnet.net
We are actively looking for companies that do a lot of long
distance faxing and want to cut their long distance bill by
up to 50%. Contact [EMAIL PROTECTED] for more info.
sqwebmail-3.5.0.20030303.patch.tar.gz
Description: application/tgz
