Jesse,
Ok, I tested most of the features in this latest patch and everything works.
The problem that existed in the previous version with
domain1:domain2
appears to have been fixed - I no longer have to put a : at the end.
I read the doc and that certainly clears up more things. A lot of things
that I objected to in the past are all resolved. Your current choices for
the modifiers are pretty minimalist, and solve what I think were your goals
and mine, in terms of minimizing administrative efforts. It is somewhat of
an "implementors interface" (or like you said "modifier-centric"), but with
only 2 modifiers to keep track of this doesn't really bother me. Let's put
it this way: I would have used 2 modifiers, and you have used 2 modifiers.
Details may have differed but where we disagree your opinion is as good as
mine.
Probably some minor feedback on the doc later, and I will look at your code
and point out anything that comes to mind.
There might be a couple other truly minor points if I go back through all my
comments to find them - corner case kinds of things that I want to make sure
didn't get neglected. But I am also ready to bring this to a close, since
this has actually been a lot of work for me too, in spite of not writing
code - mainly because of installing and testing each version that came
along, and of course writing all my comments, which I made into more work
than necessary.
Thanks again for all,
Kurt Bigler
on 3/4/03 9:42 AM, Jesse Guardiani <[EMAIL PROTECTED]> wrote:
> Greetings list,
>
> Submitted in this email, for your testing, is the fourth
> (and by far the best) incarnation of my logindomainlist
> patch.
>
> To apply the patch, simply unzip and untar it, then
> execute something like the following:
>
> patch sqwebmail-3.5.0.20030301/sqwebmail/sqwebmail.c <
> sqwebmail-3.5.0.20030304.patch
>
> It's diffed against the sqwebmail-3.5.0.20030215 release,
> but it works fine with the newer sqwebmail-3.5.0.20030301
> release as well. (I've tested it.)
>
>
> What's New?
> -----------
>
> 1.) Code cleanup and restructuring. The old code structure
> was making it difficult to write bug free code. The new
> code structure should make it easy. Many things were
> broken out into separate functions, including the code
> in the main template parsing loop. This has an added
> side effect of making the code a bit easier to follow.
>
> 2.) Bug fixes! Fixed a bug that caused sqwebmail to crash
> if the logindomainlist file had two fields per record
> instead of one or three.
>
> Also, fixed a bug that caused the following record:
>
> domain.com:domain.com:*
>
> To ALWAYS match as long as it was actually reached
> when sqwebmail scans the logindomainlist file.
>
> This kind of record now only matches if domain.com is
> in the calling URL (the way it's supposed to be).
>
> This release has been tested and is running on two of my
> production machines. I'm SURE it still has a few bugs in it,
> but I couldn't find them.
>
> Please install this new version on your servers and help
> me test it.
>
> Thanks,
