Ok, if you are saying your configuration fix would correctly work to check the
address type at run-time, then I guess it would work. Otherwise, it would be
all IPv6 or all IPv4.
The fix you added that adds the brackets automatically at run-time for $siz is
the best way actually, as then you do not need cryptic configuration files.
So, in any case, thanks very much for adding the new function that
automatically adds the brackets when needed.
If I have permission from Verizon, I might like to contribute in the future. I
can see a need to immediately parse the incoming messages and immediately
reject any message with any part not formed correctly, rather than passing bad
things through the code and crashing later. Also, would be good to switch to
not use the old depricated system calls for networking (avoids dangerous
mucking with the IP address structures and also avoid case switches for IPv4 vs
IPv6). The new calls reduce the specific code for IPv4 vs IPv6 to an absolute
minimum. I would also use the system calls to convert IP address to string
instead of the hand written ones, etc.
Don.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1136#issuecomment-310512913
_______________________________________________
Kamailio (SER) - Development Mailing List
[email protected]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
