Thanks for the contribution!
The option to enable features in a module with compile time defines is not
preferred at all. We had in the past the RADIUS (and DIAMETER) accounting as
part of acc and it was very inconvenient to maintain or package.
The solution is to implement this as a new module on top of acc module, like
`acc_json`, similar to `acc_radius`. In this way the module doesn't have
compile time defines and can be packaged separately as part of jansson-modules
pkg.
It should be very easy to build the new module by reusing the code you have in
this patch. I did the split of acc_radius module.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1437#issuecomment-365178761
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
