<!-- Kamailio Pull Request Template -->

  - for detailed contributing guidelines, read:
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, 
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines 
from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev 
mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes 
that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->
Currently we need a onsend_route{} (empty is ok) block in config before KEMI 
ksr_onsend_route() is invoked. The latter will override the route block.

This PR will unconditonally invoke KEMI ksr_onsend_route() so we do not need a 
placeholder in config.

For discussion: this will unconditionally invoke ksr_onsend_route() so it might 
break scripts that don't have an implementation. Should be document that 
ksr_onsend_route should be implemented (just return 1 is ok).

I'm not too clear about the error handling in run_onsend(): it's possible that 
if KEMI ksr_onsend_route throws error (not implemented rather than real error) 
then the message might be dropped.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * core: invoke KEMI ksr_onsend_route()

-- File Changes --

    M src/core/onsend.h (7)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Kamailio (SER) - Development Mailing List

Reply via email to