Thank you both of you. I already have github account (username: *mshary*) and i will proceed with updated patch as you guys have mentioned.
Thank you. On Mon, May 7, 2018 at 10:23 PM, Daniel-Constantin Mierla <[email protected] > wrote: > Hello, > > somehow I missed the email with patches -- I pushed in the morning the > commit to fix the warnings I introduced with the patch over the weekend, as > I had it in mind to finish those changes, before checking dev list, > hopefully not breaking that much your work to avoid wasting too much time > to redo patches. > > As Henning said, better make a pull request with your improvements, it is > easier to review and merge. > > Cheers, Daniel > > On 07.05.18 21:17, Henning Westerholt wrote: > > Am Samstag, 5. Mai 2018, 13:45:59 CEST schrieb M S: > > > I have updated and tested db_perlvdb module > > > (using Kamailio::VDB::Adapter::Describe) and it seems to work perfectly > now. > > > > > > Please find attached two patches which apply changes to both code and > > > documentation of this module. Kindly review and merge them to appropriate > > > branches as mentioned below, > > > > > > The first patch "*db_perlvdb-kamailio-5x.patch*" is for Kamailio v5.0 > and > > > v5.1 branches. Theoretically this patch will work for kamailio v4.x > > > branches too however, since directory structure of kamailio changed since > > > v5.0, so some manual work is required to fix file paths mentioned in > patch > > > file. > > > > > > The second patch "*db_perlvdb-kamailio-master.patch*" is for kamailio > > > master branch. > > > > Hello, > > > > thank you for the patch. Daniel applied in commit 6a152024 already some of > the const compile warning changes. But some parts of your patch are still > missing, you also improved some cleanup functions. > > > > Could you please re-base your patch against current master and create an > pull request at our kamailio github? Its rather easy, just a few clicks > given you have a github account. > > > > I noticed that you changed the module README as well - please change the > module _admin.xml file instead. The README is autogenerated and should not > be changed in a patch. > > > > After that I will have a look to the pull request and can apply the > changes. > > > > Best regards, > > > > Henning > > > -- > Daniel-Constantin Mierlawww.twitter.com/miconda -- www.linkedin.com/in/miconda > Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com > >
_______________________________________________ Kamailio (SER) - Development Mailing List [email protected] https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
